tawasuyu

tawasuyu/taffy

A high performance rust-powered UI layout library

Rust 501HTML 254C 19JavaScript 81414 Sutichaykuna

Remove dead Overflow type (#112)

* Remove dead Overflow type

* Update RELEASES

7e3ababdbb970183819ef07221c64d509ff39807 · ruwaq Alice Cecile · (4 wata ñawpaq) · tayta 724e286c8 · kay commitpi sach'ata qhaway

Semántico sayk'uy · 4

src/style.rs

3 qillqakuna · +4 −20

diff --git a/RELEASES.md b/RELEASES.md
index ee69fbb5e..19285a3bd 100644
--- a/RELEASES.md
+++ b/RELEASES.md
@@ -20,8 +20,8 @@
   - more serious refactors are planned, and this will be challenging to keep working through that process
   - if you are interested in helping us maintain bindings to other languages, [get in touch](https://github.com/DioxusLabs/sprawl/discussions)!
 - the `serde_camel_case` and `serde_kebab_case` features have been removed: they were poorly motivated and were not correctly additive (if both were enabled compilation would fail)
-- removed the `Direction` struct, and the corresponding `direction` field from `Style`
-  - this had no effect in the current code base and was actively misleading
+- removed the `Direction` and `Overflow` structs, and the corresponding `direction` and `overflow` fields from `Style`
+  - these had no effect in the current code base and were actively misleading
 
 ## stretch2 0.4.3
 
diff --git a/src/prelude.rs b/src/prelude.rs
index 3ac56a956..abc9c55ee 100644
--- a/src/prelude.rs
+++ b/src/prelude.rs
@@ -4,8 +4,8 @@ pub use crate::{
     node::{Node, Sprawl},
     number::Number,
     style::{
-        AlignContent, AlignItems, AlignSelf, Dimension, Display, FlexDirection, FlexWrap, JustifyContent, Overflow,
-        PositionType, Style,
+        AlignContent, AlignItems, AlignSelf, Dimension, Display, FlexDirection, FlexWrap, JustifyContent, PositionType,
+        Style,
     },
     Error,
 };
diff --git a/src/style.rs b/src/style.rs
index 5abd63f4c..436173793 100644
--- a/src/style.rs
+++ b/src/style.rs
@@ -115,20 +115,6 @@ impl Default for JustifyContent {
     }
 }
 
-#[derive(Copy, Clone, PartialEq, Eq, Debug)]
-#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-pub enum Overflow {
-    Visible,
-    Hidden,
-    Scroll,
-}
-
-impl Default for Overflow {
-    fn default() -> Self {
-        Self::Visible
-    }
-}
-
 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 pub enum PositionType {
@@ -205,7 +191,6 @@ pub struct Style {
     pub position_type: PositionType,
     pub flex_direction: FlexDirection,
     pub flex_wrap: FlexWrap,
-    pub overflow: Overflow,
     pub align_items: AlignItems,
     pub align_self: AlignSelf,
     pub align_content: AlignContent,
@@ -230,7 +215,6 @@ impl Default for Style {
             position_type: Default::default(),
             flex_direction: Default::default(),
             flex_wrap: Default::default(),
-            overflow: Default::default(),
             align_items: Default::default(),
             align_self: Default::default(),
             align_content: Default::default(),